Add examples for Express Route Circuit APIs #3182

gimotwanMSFT · 2018-06-05T01:45:23Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-06-05T01:46:53Z

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpqcrn858v/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpqcrn858v/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Shutting Down
Shutting Down
FATAL: java/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.

AutorestCI · 2018-06-05T01:47:39Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpzrzbqr3m/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpzrzbqr3m/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.59)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.

AutorestCI · 2018-06-05T02:11:55Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1348

AutorestCI · 2018-06-05T02:19:41Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2689

AutorestCI · 2018-06-05T02:30:39Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp3xcuewpe/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp3xcuewpe/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.100', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.100->2.1.100)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-04"} .
Processing batch task - {"tag":"package-2018-02"} .
Processing batch task - {"tag":"package-2018-01"} .
Shutting Down
FATAL: go/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Failure during batch task - {"tag":"package-2018-01"} -- false.

sergey-shandar

LGTM

* Add examples for Express Route Circuit APIs * Fix errors in expressRouteCircuit.json validations * Fix errors in validate examples for ExR Circuit

…1) (#3261) * Added Network 2018-06-01; VM ref fix (#3118) * Init 2018-06-01 (copy from 2018-05-01) * Make VM reference in NIC readonly * Updated version in readme * New VPN Client Protocol (#3133) * Added new VPN protocol * indents * Add examples for Express Route Circuit APIs (#3182) * Add examples for Express Route Circuit APIs * Fix errors in expressRouteCircuit.json validations * Fix errors in validate examples for ExR Circuit * appgwv2 changes (#3192) * AppGW FIPS mode (#3202) * Release of Azure Networking Network-2018-06-01 branch (api-version 2018-04-01) * Adding VirtualWan Swagger (#3204) * Adding VirtualWan Swagger * Adding the CRUD Apis for VpnConnections * Updating VpnGateway examples * Fixing build errors * Addressing comments * Addressing comments and editing VpnConnection definition and corresponding examples * Addressing comments * Removing enableRateLimiting property * Addressing comments * Changing the version to 2018-04-01 version * Suppress ConnectionSharedKey model issue * Reverted extra-changes in readme

jhendrixMSFT · 2018-06-21T23:02:20Z

@AutorestCI regenerate azure-sdk-for-go

AutorestCI · 2018-06-21T23:02:36Z

Encountered an unknown error

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/bot_framework.py", line 104, in manage_comment
    response = getattr(self.handler, orderstr)(webhook_data.issue, *split_text)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/restbot.py", line 53, in regenerate
    clean_sdk_pr(rest_pr, sdk_repo)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 288, in clean_sdk_pr
    msg = upstream.push(":"+sdk_pr_head)  # old style delete
  File "/usr/local/lib/python3.6/dist-packages/git/remote.py", line 843, in push
    return self._get_push_info(proc, progress)
  File "/usr/local/lib/python3.6/dist-packages/git/remote.py", line 729, in _get_push_info
    proc.wait(stderr=stderr_text)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 415, in wait
    raise GitCommandError(self.args, status, errstr)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --porcelain upstream :restapi_auto_3182
  stderr: 'error: unable to delete 'restapi_auto_3182': remote ref does not exist
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-go.git''

Adding support for VM extensions to connected VMware virtual machines...

Add examples for Express Route Circuit APIs

ff7010e

gimotwanMSFT requested review from DeepakRajendranMsft and MikhailTryakhov as code owners June 5, 2018 01:45

azuresdkci assigned sergey-shandar Jun 5, 2018

azuresdkci requested a review from sergey-shandar June 5, 2018 01:46

AutorestCI mentioned this pull request Jun 5, 2018

[AutoPR network/resource-manager] Add examples for Express Route Circuit APIs Azure/azure-sdk-for-ruby#1348

Merged

AutorestCI mentioned this pull request Jun 5, 2018

[AutoPR network/resource-manager] Add examples for Express Route Circuit APIs Azure/azure-sdk-for-python#2689

Merged

Fix errors in expressRouteCircuit.json validations

cfb31fb

AutorestCI mentioned this pull request Jun 5, 2018

[AutoPR network/resource-manager] Add examples for Express Route Circuit APIs Azure/azure-sdk-for-go#1962

Closed

This was referenced Jun 5, 2018

[AutoPR network/resource-manager] Add examples for Express Route Circuit APIs AutorestCI/azure-libraries-for-java#225

Open

[AutoPR network/resource-manager] Add examples for Express Route Circuit APIs Azure/azure-sdk-for-node#2944

Closed

Fix errors in validate examples for ExR Circuit

a724044

sergey-shandar approved these changes Jun 5, 2018

View reviewed changes

MikhailTryakhov approved these changes Jun 5, 2018

View reviewed changes

MikhailTryakhov merged commit ea81162 into Azure:Network-2018-06-01 Jun 5, 2018

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Merge pull request #3182 from Azure/dev/subbart/vmextensions

30dcee4

Adding support for VM extensions to connected VMware virtual machines...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add examples for Express Route Circuit APIs #3182

Add examples for Express Route Circuit APIs #3182

gimotwanMSFT commented Jun 5, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

sergey-shandar left a comment

jhendrixMSFT commented Jun 21, 2018

AutorestCI commented Jun 21, 2018

Add examples for Express Route Circuit APIs #3182

Add examples for Express Route Circuit APIs #3182

Conversation

gimotwanMSFT commented Jun 5, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Jun 5, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Jun 5, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jun 5, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 5, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 5, 2018 • edited Loading

Automation for azure-sdk-for-go

sergey-shandar left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Jun 21, 2018

AutorestCI commented Jun 21, 2018

gimotwanMSFT commented Jun 5, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading

AutorestCI commented Jun 5, 2018 •

edited

Loading